[DVDnav-discuss] please review: DVDFileStat, close dev on error, use parens and BSD porting bits

Erik Hovland erik at hovland.org
Mon Aug 31 18:05:04 CEST 2009

> fine, but please fix those horrible
> - if (  x  )
> and
> if (  y  ) {
>  empty line
> }
> syntaxes.

I hate to bother, but could you be more specific? Does it mean
you prefer 'if(x)' over if( x )? The empty line I get.

Attached is a new DVDFileStat patch w/ the whitespace
removed and the parens format made to match that of the
functions on either side of the newly add functions.

I am assuming that since niether Diego or Nico has said
anything else about the other three patches, that they are
generally OK.


Erik Hovland
erik at hovland.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-DVD-file-stat-from-version-0.9.7-to-libdvdread.patch
Type: text/x-diff
Size: 7982 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20090831/afa559bf/attachment.patch>

More information about the DVDnav-discuss mailing list