[DVDnav-discuss] please review: DVDFileStat, close dev on error, use parens and BSD porting bits

Nico Sabbi nicola.sabbi at poste.it
Mon Aug 31 09:58:42 CEST 2009


Il lunedì 31 agosto 2009 02:24:56 Erik Hovland ha scritto:
> I finally got my act together on the whoe dvdnav/dvdread svn write
> access. So I am
> asking for a last review before I commit these patches to the repo.
>
> 0001 The already sent (and already approved) DVDFileStat addition
> to the API 0002 Close a dvd file struct in an error path (another
> finger in the proverbial dike)
> 0003 Use parens to make mask off of 'is present' bit explicit
> 0004 Add the *BSD bits from libdvdread 0.9.7
>
> Thanks
>
> E
>

fine, but please fix those horrible 
- if (  x  ) 
and
if (  y  ) {
  empty line

}

syntaxes.


More information about the DVDnav-discuss mailing list