[MPlayer-dev-eng] [PATCH] ao_dart

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Thu, Feb 26, 2009 at 05:02:09AM +0900, KO Myung-Hun wrote:
>   
>> [...]
>>     
>
> Your patch fails to apply, so here is another round of nitpicks
> instead of a commit...
>
>   
>> --- libao2/ao_dart.c	(revision 0)
>> +++ libao2/ao_dart.c	(revision 0)
>> @@ -0,0 +1,332 @@
>> +
>> +static ao_info_t info =
>> +{
>>     
>
> The opening brace should be on the same line for K&R style...
>
>   

Fixed.

>> +static int buf_free(void) {
>>     
>
> ...but on the next line for function declarations...
>
>   

Fixed.

>> +static int control(int cmd, void *arg)
>> +{
>> +    switch (cmd) {
>> +        case AOCONTROL_GET_VOLUME :
>>     
>
> ...and the case at the same indentation depth as the switch.
>
>   

Fixed. But, now the closing bracket '}' of last case is placed on the 
same depth with the closing bracket '}' of switch. I think it's not good 
style.

>> +    int     fShare       = 1;
>> +    int     nDartSamples = DEFAULT_DART_SAMPLES;
>> +    int     nBytesPerSample;
>>     
>
> weird amount of spaces
>
>   

Fixed.

>> +static int play(void *data, int len, int flags)
>> +{
>> +
>> +     if (!(flags & AOPLAY_FINAL_CHUNK))
>> +        len = (len / ao_data.outburst) * ao_data.outburst;
>> +
>> +     return write_buffer(data, len);
>>     
>
> one space indentation too much
>
>   

Fixed. I think you have a eagle's eye. ^^

> Please make sure your patches really apply.
>
>   

Strange, it works fine here.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dart.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090226/82e7b37f/attachment.asc>