[MPlayer-dev-eng] [PATCH] ao_dart

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Feb 26 09:23:43 CET 2009


On Thu, Feb 26, 2009 at 12:18:54AM +0100, Diego Biurrun wrote:
> > +static int buf_free(void) {
> 
> ...but on the next line for function declarations...
> 
> > +static int control(int cmd, void *arg)
> > +{
> > +    switch (cmd) {
> > +        case AOCONTROL_GET_VOLUME :
> 
> ...and the case at the same indentation depth as the switch.

I guess these are because it is based on code from me.
I don't mind much the {-placement (though I consider it a waste of
space), but I always found placing the case at the same level as the
switch a certain way to make it quite unreadable (particularly finding
the closing } becomes harder).
Anyway, I just notice that there is also a space before the ':' which
could be removed.



More information about the MPlayer-dev-eng mailing list