[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 7

Carl Eugen Hoyos cehoyos at ag.or.at
Mon Feb 9 01:03:11 CET 2009


Diego Biurrun <diego <at> biurrun.de> writes:

> > + * VDPAU vo device with X11 for MPlayer
> 
> That's not a very informative line.  At least do s/device/driver/ and
> drop "MPlayer".  What else would this be if not MPlayer?

Very true.

> > +    // Creation of VideoMixer.
> > +static int create_vdp_mixer(VdpChromaType vdp_chroma_type) {
> 
> This is the only // comment, it is weirdly indented and useless.

It is (I wanted to drop it but forgot)!

> > +/*
> > + * connect to X server, create and map window, initialize all
> 
> Capitalize.

All fixed locally.

> Rest looks OK from my side.

Thank you for looking, Carl Eugen




More information about the MPlayer-dev-eng mailing list