[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 7

[Diego Biurrun]

On Thu, Feb 05, 2009 at 11:23:57PM +0100, Carl Eugen Hoyos wrote:
>
> Attached is a hopefully improved version of vo_vdpau.
> -fixed-vo tested, -fs regression fixed
>
> --- libvo/vo_vdpau.c	(revision 0)
> +++ libvo/vo_vdpau.c	(revision 0)
> @@ -0,0 +1,711 @@
> +/*
> + * VDPAU vo device with X11 for MPlayer

That's not a very informative line.  At least do s/device/driver/ and
drop "MPlayer".  What else would this be if not MPlayer?

> +    // Creation of VideoMixer.
> +static int create_vdp_mixer(VdpChromaType vdp_chroma_type) {

This is the only // comment, it is weirdly indented and useless.

> +/*
> + * connect to X server, create and map window, initialize all

Capitalize.

Rest looks OK from my side.

Diego