[MPlayer-dev-eng] [RFC] prefix for multiple inclusion guards

Diego Biurrun diego at biurrun.de
Fri Feb 22 10:22:20 CET 2008


On Thu, Feb 21, 2008 at 12:57:42AM +0100, Diego Biurrun wrote:
> On Mon, Feb 18, 2008 at 07:24:28PM +0100, Diego Biurrun wrote:
> > On Mon, Feb 18, 2008 at 01:22:00PM -0500, Rich Felker wrote:
> > > On Mon, Feb 18, 2008 at 07:14:07PM +0100, Diego Biurrun wrote:
> > > > So we have consistent multiple inclusion guards now, but some of them
> > > > are a little bit generic (MMX_H and PNM_H come to mind).  I propose
> > > > giving all of them an MPlayer_ prefix to solve any namespace issues that
> > > > might arise.  I'll do the work.  Objections?
> > > 
> > > I really don't like mixed case in #defines. What about just MP_ ?
> > 
> > Ummm, that was just a typo, I agree with you.  I meant MPLAYER_.
> 
> And what do we do about parts that are considered separate from MPlayer
> like VIDIX and maybe loader/?  Should they get their own prefix like
> LIBASS_?  In vidix/ some files have a VIDIX_ prefix, most don't...

Committed without vidix/ and loader/ for now.  What about them?  If
nobody speaks up I will give them a MPLAYER_ prefix as well.

Diego



More information about the MPlayer-dev-eng mailing list