[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Guillaume POIRIER]

Hello,

On Mon, Dec 15, 2008 at 1:37 PM, Gregor Riepl <onitake at gmail.com> wrote:
>> Typically, your application doesn't need to call this. If your
>> application
>> has the Quit menu item tagged with the kHICommandQuit menu command
>> ID, the
>> toolbox will automatically call this for your application,
>> automatically
>> terminating your event loop. If your application wants to do pre-
>> processing
>> before the event loop exits, it should intercept either the
>> kHICommandQuit menu
>> command, or the kEventAppQuit event.
>>
>> I don't see further reason to not remove that call now.
>
> yes, i saw that part too. that's why i didn't bother finding a
> replacement.
> and quitting (via cmd-q or q) worked just fine without
> QuitApplicationEventLoop.

Confirmed. I wonder if that call is there only so that MPlayerOSX
works fine... We'll see how things go once this change gets merged.


> by the way, i checked the assembly incompatibilites. looks like a lot
> of work.
> in some places, simply modifying the MANGLE macro would work (adding a
> (%%rip) to it), but in others, this will fail. using __asm__
> constraints is another possibility, but will also not work everywhere.
> gcc showed some inconsistent behaviour, which would have to be worked
> around.
> the best way might be writing special 64bit versions of the routines,
> and they could also take advantage of the additional registers. but i
> doubt people will approve to this, as it's a lot of work, complicates
> code and provides little performance gain. i did a quick speed test
> with 32bit and 64bit compilation (with added registers) of vf_fspp.c,
> but noticed no significant difference.

vf_fspp.c doesn't need modified ASM. It can compile fine if you change
optimization level from -O4 to -O2.
The rest of the code that doesn't compile in 64-bits is liba52, which
in a way should not matter much since FFmpeg has experimental have
full AC3 support...


> this doesn't mean it's a good idea to get rid of deprecated calls,

Well, besides QuitApplicationEventLoop, deprecated calls have been
dealt with already, right?


> but it makes a 64bit os x port more questionable. to me at least.

It's a good idea to work on this in advance, before many users ask for
it. Also, this enables to use MEncoder in 64-bits mode, which is quite
cool since most codecs are faster when compiled in 64-bits mode.


Guillaume
-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Robert Orben  - "Older people shouldn't eat health food, they need all
the preservatives they can get."