[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Gregor Riepl]

> Typically, your application doesn't need to call this. If your  
> application
> has the Quit menu item tagged with the kHICommandQuit menu command  
> ID, the
> toolbox will automatically call this for your application,  
> automatically
> terminating your event loop. If your application wants to do pre- 
> processing
> before the event loop exits, it should intercept either the  
> kHICommandQuit menu
> command, or the kEventAppQuit event.
>
> I don't see further reason to not remove that call now.

yes, i saw that part too. that's why i didn't bother finding a  
replacement.
and quitting (via cmd-q or q) worked just fine without  
QuitApplicationEventLoop.

by the way, i checked the assembly incompatibilites. looks like a lot  
of work.
in some places, simply modifying the MANGLE macro would work (adding a  
(%%rip) to it), but in others, this will fail. using __asm__  
constraints is another possibility, but will also not work everywhere.  
gcc showed some inconsistent behaviour, which would have to be worked  
around.
the best way might be writing special 64bit versions of the routines,  
and they could also take advantage of the additional registers. but i  
doubt people will approve to this, as it's a lot of work, complicates  
code and provides little performance gain. i did a quick speed test  
with 32bit and 64bit compilation (with added registers) of vf_fspp.c,  
but noticed no significant difference.

this doesn't mean it's a good idea to get rid of deprecated calls, but  
it makes a 64bit os x port more questionable. to me at least.