[MPlayer-dev-eng] [PATCH] use yasm macho in configure

Guillaume Poirier gpoirier at mplayerhq.hu
Mon Dec 1 18:01:35 CET 2008


Hello,

Andrew Wason wrote:
> Anyone object to applying the patch to configure referenced in this thread?
> http://lists.mplayerhq.hu/pipermail/mplayer-users/2008-November/075150.html
>
> It changes yasm obj format from macho32 to macho for Mac.  I've been running
> mplayer with the patch for a week now and seen no issues, without it I have
> dozens of files that mplayer crashes on.
>   

This is not the right way to fix the problem IMHO. Also, it looks like
you forgot to attach the patch :-P


> I think the issue is libavcodec/i386/x86inc.asm is conditionally compiled based
> on __OUTPUT_FORMAT__ for macho64 or macho - and so when macho32 is used it does
> not match macho and ends up using the %else case.

Yep, good diagnostic. I'm gonna submit a patch to FFmpeg mailing list to
fix this.

Guillaume



More information about the MPlayer-dev-eng mailing list