[MPlayer-dev-eng] [PATCH] Fix parse comment bug for input.conf

Ulion ulion2002 at gmail.com
Tue Oct 16 15:43:42 CEST 2007


2007/10/16, Rich Felker <dalias at aerifal.cx>:
> On Tue, Oct 16, 2007 at 03:02:04PM +0800, Ulion wrote:
> > Hello,
> >
> > For a reported bug:
> > http://lists.mplayerhq.hu/pipermail/mplayer-users/2007-October/069603.html
> > I tested, it is a bug when parsing input comand followed by comment in
> > the same line.
> > I make a patch for this, so when parse cmd, comment will be ignored.
>
> Are you sure this does not break bindings/commands with # in them?
>
> Rich

This only break bindings/commands with # as the first char of a
parameter, that only has meaning for string parameter. But for this
situation, the parameter can be quoted by " or ' to has a leading '#'.

Check current truck/etc/input.conf, not only one line has comment
after commands, it already broke the commands. Any other way to fix it
better?

-- 
Ulion



More information about the MPlayer-dev-eng mailing list