[MPlayer-dev-eng] [PATCH] stream layer support for .ifo files

Nico Sabbi Nicola.Sabbi at poste.it
Fri Nov 30 23:52:23 CET 2007


Il Friday 30 November 2007 23:42:59 Nico Sabbi ha scritto:

> > Is it okay to apply or sth inflammable ?
> >
> > If okay, I might add some later option for prefered ifo file
> > playback (i.e. dvd:// or dvdnav://)
> >
> > Ben
>
> if you really insist on committing this code you can at
> least minimize the nonsense and add the stream definition
> and the function in stream_dvd.c
> _______________________________________________


Index: stream/stream.c
===================================================================
--- stream/stream.c     (revision 25214)
+++ stream/stream.c     (working copy)
@@ -85,6 +85,7 @@
 extern stream_info_t stream_info_mf;
 extern stream_info_t stream_info_file;
 #ifdef USE_DVDREAD
+extern stream_info_t stream_info_ifo;
 extern stream_info_t stream_info_dvd;
 #endif
 
@@ -132,6 +133,7 @@
 #endif
   &stream_info_cue,
 #ifdef USE_DVDREAD
+  &stream_info_ifo,
   &stream_info_dvd,
 #endif
 #ifdef USE_DVDNAV
@@ -189,6 +191,10 @@
     }
     streaming_ctrl_free(s->streaming_ctrl);
 #endif
+#ifdef USE_DVDREAD
+    if (*ret == STREAM_REDIRECTED && s->type == STREAMTYPE_DVD)
+      *redirected_url = strdup("dvd://");
+#endif

BTW, this is totally unacceptable. I didn't spend my
time adapting all stream readers to the new api to see
my effort vanified with the reintroduction of special
cases handling.

BTW2, using the "file"  prefix doesn't permit to identify
the stream type unequivocally; better use ifo:// instead




More information about the MPlayer-dev-eng mailing list