[MPlayer-dev-eng] [PATCH] Activating/Deactivating of XScreenSaver

[Diego Biurrun]

Joachim Breitner writes:
 > 
 > Am 2002.06.01 16:43 schrieb(en) Diego Biurrun:
 > > It works, after I changed
 > > 
 > >   int stop_xscreensaver=0;
 > > 
 > > to 
 > > 
 > >   int stop_xscreensaver=1;
 > 
 > This was intended. You have to use the option -stop_xscreensaver or
 > write stop_xscreensaver in the option-file.

OK, I did not realize that.

 > > xscreensaver gets stopped and restarted after mplayer quits.  If I do
 > > a 'killall -9 mplayer' xscreensaver does not get restarted, though.
 > 
 > That is true, I'm afraid. But doesn't the same thing happen to the
 > ScreensaverExtension (the builtin X11-Screensaver)? I added my code
 > right next to these lines.

IIRC the builtin screensaver does not lock the screen, does it?

 > > Since xscreensaver is used for locking the screen, a crashing mplayer
 > > can be a security hole, because the screen will not be locked again
 > > and the user is probably not aware of this.
 > 
 > This is why this option should not be default. But for a lot of people that
 >  * Don't lock
 >  * Don't crash their mplayer (didn't happen to me a single time) / reboot regularily
 > this is still a good solution.

Most definitely.  I love it.

Diego