[MPlayer-dev-eng] [PATCH] Activating/Deactivating of XScreenSaver

[Joachim Breitner]

Hello,

nice to see such a quick answer.

Am 2002.06.01 16:43 schrieb(en) Diego Biurrun:
> It works, after I changed
> 
>   int stop_xscreensaver=0;
> 
> to 
> 
>   int stop_xscreensaver=1;

This was intended. You have to use the option -stop_xscreensaver or write stop_xscreensaver in the option-file. This _is_ a dirty hack, but the best thing available if we don't want to xscreensaver-command -disable every minute or somebody writes a xscreensaver-command pause/unpause-thing.
 
> xscreensaver gets stopped and restarted after mplayer quits.  If I do
> a 'killall -9 mplayer' xscreensaver does not get restarted, though.

That is true, I'm afraid. But doesn't the same thing happen to the ScreensaverExtension (the builtin X11-Screensaver)? I added my code right next to these lines.

> Since xscreensaver is used for locking the screen, a crashing mplayer
> can be a security hole, because the screen will not be locked again
> and the user is probably not aware of this.

This is why this option should not be default. But for a lot of people that
 * Don't lock
 * Don't crash their mplayer (didn't happen to me a single time) / reboot regularily
this is still a good solution.

> I will still keep this patch applied to my local tree, my workstation
> does not need to be locked :-)
> 
>  > I would like to see this functionality because I'm about to getting
>  > used to move the mouse every 9 minutes while watching a move...
> 
> This is my pet peeve, too, and a very nice feature, I believe.  Movie
> players should disable screensavers.

Thank you. This is actually my first open-source contribution, so I'm especially glad to hear that it's useful.

 
-- 
Joachim Breitner 
	mail at joachim-breitner.de | http://www.joachim-breitner.de | ICQ: 74513189
Zufälliger Spruch/Random Fortune:

martin at bdsi.com (no longer valid - where are you now, Martin?)
	-- from /usr/src/linux/drivers/cdrom/mcd.c