[MPlayer-dev-eng] [PATH] libmpdvdkit and tvi_bsdbt848 on NetBSD

Arpi arpi at thot.banki.hu
Sun Apr 28 19:38:16 CEST 2002


Hi,

> +/* This should be done in configure but for now kludge it. */
> +#if defined(__NetBSD__)
> +#undef HAVE_BSD_DVD_STRUCT
> +#define HAVE_LINUX_DVD_STRUCT 1
> +#endif

ok, what about this:

  _def_dvd_linux='#undef HAVE_LINUX_DVD_STRUCT'
  _def_dvd_bsd='#undef HAVE_BSD_DVD_STRUCT'
  if linux || netbsd || openbsd ; then
    _def_dvd_linux='#define HAVE_LINUX_DVD_STRUCT 1'
  else
    if freebsd || bsdos ; then
     _def_dvd_bsd='#define HAVE_BSD_DVD_STRUCT 1'
    fi
  fi

so, if i understood right, netbsd and openbsd has linux-style dvd struct,
while bsd/os, freebsd has bsd-style?

> -#include <machine/soundcard.h>
> +#ifdef HAVE_SOUNDCARD_H
> +#include <soundcard.h> /* NetBSD/OpenBSD have this instead of <sys/soundcar
> d> */
> +#endif

fixed

about the idea of disabling libmpdvdkit:
you can disable it, if you want. but i don't agree on disabling it if
libdvdread/libdvdcss found, as libdvdkit has some critical and some usefull
patches applied, still missing from official libdvd* releases.

also note, that mplayer won't work with ogle's dvdcss 1.0


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list