[rtmpdump] branch master updated. ee5456b Update OpenSSL support

Dominik 'Rathann' Mierzejewski dominik at greysector.net
Fri Mar 1 16:00:45 EET 2024


Hello, Howard.
Unfortunately, this breaks building with GnuTLS, e.g.:

make CRYPTO=GNUTLS
...
gcc -Wall   -DRTMPDUMP_VERSION=\"v2.4\" -DUSE_GNUTLS  -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fPIC   -c -o rtmp.o rtmp.c
In file included from handshake.h:93,
                 from rtmp.c:153:
dh.h: In function ‘DHInit’:
dh.h:269:3: error: implicit declaration of function ‘DH_set0_pqg’ [-Wimplicit-function-declaration]
  269 |   DH_set0_pqg(dh, p, NULL, g);
      |   ^~~~~~~~~~~
dh.h:271:3: error: implicit declaration of function ‘DH_set_length’ [-Wimplicit-function-declaration]
  271 |   DH_set_length(dh, nKeyBits);
      |   ^~~~~~~~~~~~~
dh.h: In function ‘DHGenerateKey’:
dh.h:296:28: error: implicit declaration of function ‘DH_get0_pub_key’ [-Wimplicit-function-declaration]
  296 |           MP_t key = (MP_t)DH_get0_pub_key(dh);
      |                            ^~~~~~~~~~~~~~~
dh.h:296:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  296 |           MP_t key = (MP_t)DH_get0_pub_key(dh);
      |                      ^
dh.h:297:26: error: implicit declaration of function ‘DH_get0_p’ [-Wimplicit-function-declaration]
  297 |           MP_t p = (MP_t)DH_get0_p(dh);
      |                          ^~~~~~~~~
...

It looks like you've added some OpenSSL-specific function calls without
wrapping them.

Regards,
Dominik
-- 
Fedora   https://fedoraproject.org
Deep in the human unconscious is a pervasive need for a logical universe that
makes sense. But the real universe is always one step beyond logic.
        -- from "The Sayings of Muad'Dib" by the Princess Irulan


More information about the rtmpdump mailing list