[rtmpdump] [PATCH] Make rtmpdump handle full RTMP URLs with "-i"

compn tempn at twmi.rr.com
Thu Jul 19 04:24:23 CEST 2012

On Wed, 18 Jul 2012 23:27:44 +0100, Bastien Nocera wrote:
>On Wed, 2012-07-18 at 17:14 -0500, Steven Penny wrote:
>> On Jul 18, 2012 Bastien Nocera wrote
>> > Make rtmpdump handle full RTMP URLs with "-i" or --url. The library already
>> > can handle those, so it makes debugging easier for users of the library.
>> This is redundant code. RtmpDump already supports these options via
>>   --protocol
>>   --host
>>   --port
>>   --app
>>   --swfUrl
>>   --tcUrl
>> Additionally, in many cases tcUrl is assumed based on the app/playpath. I say if
>> you want to see this pass you will bring some more discussion to the table than
>> "Short sentence commit message".
>The library uses the parsed URL, but the command-line application can't?
>Seems weird.
>I'm writing code that generates those sort of URLs, which are understood
>by applications like Totem, VLC, XBMC, or mplayer (through librtmp). It
>makes complete sense that the low-level utility that's rtmpdump supports
>it too.

is there anyway you could move the 'fullurl' parsing code from librtmp
to a common file that rtmpdump could also be linked to, so there
wouldnt be code duplication? (if there is code duplication, anyways,
i'm not paying attention here)


More information about the rtmpdump mailing list