[rtmpdump] [PATCH] Add support for building with gnutls with nettle as backend
martin at martin.st
Mon Feb 27 10:45:52 CET 2012
On Mon, 27 Feb 2012, Howard Chu wrote:
> Martin Storsjö wrote:
>> On Sun, 26 Feb 2012, Howard Chu wrote:
>>> Since gcrypt is an utter disaster, and gnutls is using nettle as the
>>> backend now, we could just use nettle and drop gcrypt.
>> Yes, that's also totally ok with me.
>> As I wrote earlier, this is still missing some verification of the swfhash
>> codepaths, I think I've got the rest of it tested already. Once someone
>> with access to test urls that actually require the swfhash stuff has
>> verified it, please go ahead.
> Perhaps we just need to write a separate test wrapper instead; running the
> SWFhash is just a matter of hashing a known input and making sure it matches
> a known output. As long as the underlying SHA functions are correct, this
> should be easy to verify.
Right - verified that the nettle patch produces hashes identical to what
the openssl codepath does.
So I think this patch is ok to proceed now, either as is, or by removing
the gcrypt support at the same time.
More information about the rtmpdump