[rtmpdump] patch: strsignal

Howard Chu hyc at highlandsun.com
Sat Apr 9 02:21:42 CEST 2011

Peter Miller wrote:
> On Fri, 2011-04-08 at 11:31 -0700, Howard Chu wrote:
>> Peter Miller wrote:
>>> This patch adds the use of strsignal, to print a human readable signal
>>> name in the signal handler's log message.
>> Did you test this patch on Windows?
> I don't have access to windows.  I could maybe use Wine to run Cygwin.
> I've never owned a native windows compiler.  Do you know of an open
> source one?
>> I'm rejecting this patch. If it ain't broke don't fix it.
> Having to look up the signal number is unhelpful.  Having to look one up
> is what prompted me to make that change set in the first place.

Having to look up the signal number is unnecessary. That signal handler is 
only installed for two cases - SIGINT and SIGTERM. As the user, you ought to 
already know which it was. If you hit Ctrl-C then you generated a SIGINT yourself.

More information about the rtmpdump mailing list