[MPlayer-users] osdlevel regression/bug/bad behaviours

[Reimar Döffinger]

On Sun, Feb 15, 2015 at 10:59:01PM +0100, Sebastien WILLEMIJNS wrote:
> Hello,
> 
> I have windows version r37368 compiled by
> http://oss.netfarm.it/mplayer-win32.php
> 
> first kind of bug:
> With an old version (begin or mid-2014) of MPLAYER, i saw
> reminded/elapsed time of an audio file, now i only see an % not more
> (see the last line of my screentext shot below, how to do that ?

-osdlevel never had any effect on the text OSD.
The overall duration is however always displayed in the status line
for audio-only files:
A:   9.5 (09.5) of 13.9 (13.9)  0.5% 2%

> second kind of bug with 2 illogic behaviours: 
> - i tried "mplayer.exe d:\blahblah.wma -osdlevel 3 -osd-duration 1000"
> with an audio file, the % was displayed 1s as expected, osd-dfuration
> with 100 or 10000 give good behaviour, of course as explained above only
> see %
> - i tried "mplayer.exe d:\blahblah.mp4 -osdlevel 3 -osd-duration 1000"
> with a video file, osdlevel 3 gives the whole time elapsed/remained time
> + % 
> but osd-duration parameter is not used during this time...

Well, osd-duration implementation takes the documentation very
literally.
It is only applied to OSD messages.
I guess the below patch might make sense, but I'm not sure it
does quite what you want:
--- a/mplayer.c
+++ b/mplayer.c
@@ -1518,7 +1518,7 @@ void set_osd_bar(int type, const char *name, double min, double max, double val)
         return;
 
     if (mpctx->sh_video) {
-        osd_visible = (GetTimerMS() + 1000) | 1;
+        osd_visible = (GetTimerMS() + osd_duration) | 1;
         vo_osd_progbar_type  = type;
         vo_osd_progbar_value = 256 * (val - min) / (max - min);
         vo_osd_changed(OSDTYPE_PROGBAR);