[MPlayer-users] [Bug report] mplayer crash with redirected windows.
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Dec 18 19:41:23 CET 2006
Hello,
On Mon, Dec 18, 2006 at 09:18:05AM -0700, Kevin DeKorte wrote:
> Reimar Döffinger wrote:
> > On Mon, Dec 18, 2006 at 12:04:52PM +0100, Thomas Hellstr?m wrote:
> >> This division by zero bug occurs when the mozilla mplayerplug-in tries
> >> to play a CNN movie while redirecting it to a mozilla window. A full log
> >> of a gdb run is attached. If the file is played to a normal mplayer
> >> window (without the -wid option) the problem does not occur, and it
> >> doesn't always occur even with the -wid option.
> >
> > MPlayer can not render the movie in a window of size 0. This should be
> > fixed in newer mplayerplug-in, and there should also be a bugzilla entry
> > about this with a better patch that did not receive any comments though.
>
> I thought the patch to mplayer was simple enough an combined with the
> patch to mplayerplug-in (and will be in release 3.35). Things seem to be
> working ok with xv.
So did you test what I proposed in
http://bugzilla.mplayerhq.hu/show_bug.cgi?id=617#c7 and does it work?
Or can someone else confirm that the attached patch fixes the issue?
Greetings,
Reimar Döffinger
-------------- next part --------------
Index: libvo/vo_xv.c
===================================================================
--- libvo/vo_xv.c (revision 21667)
+++ libvo/vo_xv.c (working copy)
@@ -313,6 +313,8 @@
XGetGeometry(mDisplay, vo_window, &mRoot,
&drwX, &drwY, &vo_dwidth, &vo_dheight,
&drwBorderWidth, &drwDepth);
+ if (vo_dwidth <= 0) vo_dwidth = d_width;
+ if (vo_height <= 0) vo_dheight = d_height;
drwX = drwY = 0; // coordinates need to be local to the window
aspect_save_prescale(vo_dwidth, vo_dheight);
} else
More information about the MPlayer-users
mailing list