[MPlayer-users] May be atupid question/requirement

[Nico Sabbi]

Dominik 'Rathann' Mierzejewski wrote:

>On Sunday, 21 November 2004 at 11:00, Nico Sabbi wrote:
>[...]
>  
>
>>you may try this patch, but it's still under heavy development; I've 
>>been successfully using it for some time noe,
>>so it should work well. Use it this way:
>>
>>./mencoder -of mpeg -mpegopts format=dvd -ovc ... -oac ... -o file.mpg 
>><original file>
>>
>>You can also use some additional parameters (in -mpegopts) such as 
>>init_apts, init_vpts and init_adelay
>>(only negative at the moment) to fix asynchrony.
>>
>>The final file can be passed to dvdauthor.
>>    
>>
>
>Cool, I almost forgot about this patch. Any reason why it's not yet
>committed?
>  
>

It needs some more work:
1) give a way to anticipate video respect to audio
2) give the chance to drop the early part
3) understand and fix why it still doesn't keep sync with variable fps
4) it badly needs a major cleanup

Anyway, as far as I can see, it already works better than the current 
mpeg muxer in almost all cases

>  
>
>>Please let me know if it works for you.
>>    
>>
>
>Mind if I nitpick it a little first? ;)
>  
>

no problem :)

>  
>
>>Index: libmpdemux/muxer_mpeg.c
>>===================================================================
>>RCS file: /cvsroot/mplayer/main/libmpdemux/muxer_mpeg.c,v
>>retrieving revision 1.4
>>diff -c -u -c -u -r1.4 muxer_mpeg.c
>>--- libmpdemux/muxer_mpeg.c	28 Apr 2004 10:18:33 -0000	1.4
>>+++ libmpdemux/muxer_mpeg.c	21 Nov 2004 09:55:25 -0000
>>    
>>
>[...]
>  
>
>>   if (!muxer) return NULL;
>>   if(muxer->avih.dwStreams>=MUXER_MAX_STREAMS){
>>-    printf("Too many streams! increase MUXER_MAX_STREAMS !\n");
>>+    mp_dbg(MSGT_MUXER, MSGL_ERR, "Too many streams! increase MUXER_MAX_STREAMS !\n");
>>     return NULL;
>>   }
>>   switch (type) {
>>     case MUXER_TYPE_VIDEO:
>>       if (muxer->num_videos >= 15) {
>>-	printf ("MPEG stream can't contain above of 15 video streams!\n");
>>+	mp_dbg(MSGT_MUXER, MSGL_ERR, "MPEG stream can't contain above of 15 video streams!\n");
>>    
>>
>
>This should read:
>... contain more than 15 video streams!
>  
>
>> 	return NULL;
>>       }
>>       break;
>>     case MUXER_TYPE_AUDIO:
>>       if (muxer->avih.dwStreams - muxer->num_videos >= 31) {
>>-	printf ("MPEG stream can't contain above of 31 audio streams!\n");
>>+	mp_dbg(MSGT_MUXER, MSGL_ERR, "MPEG stream can't contain above of 31 audio streams!\n");
>>    
>>
>
>Likewise.
>
>R.
>
>  
>

right, fixed both