[MPlayer-G2-dev] Re: [PATCH] vo_tdfx_vid.c and vo_xover.c

[Arpi]

Hi,

> Hi Arpi,
> 
> on Thu, 17 Jul 2003 20:27:14 +0200 you wrote:
> 
> New version.
> 	Albeu

thx, mostly applied

i've fixed it for mga too, but while doing it i found a design issue :((((
dont worry, not a big thing.
currently we have VOCTRL_RESIZE_DEST, with int[4] params where -1 means
unchanged. this is bad, as -1 may be valid!
for example when the overlay window is dragged halfway outside of the screen
(window have negative x position, and so the overlay have too).
The original purpose of this control was to allow caller (UI) to do
hw-accelerated pan&scan and zoom of image. Even in that case x,y may be <0

Probably (re-)adding VOCTRL_MOVE_DEST could solve the problem, but i wanna
know if you see other posisble problems too.
(originanly it was there, but then i find that passing x,y to RESIZE_DEST
makes more sence. i was wrong...)

if no objections or better ideas, i'll go for VOCTRL_MOVE_DEST
(and VOCTRL_MOVE_SRC)


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu