[MPlayer-G2-dev] Re: [PATCH] vo_tdfx_vid.c and vo_xover.c

[Alban Bedel]

Hi Arpi,

on Sat, 19 Jul 2003 02:37:38 +0200 you wrote:

> Hi,
> 
> > Hi Arpi,
> > 
> > on Thu, 17 Jul 2003 20:27:14 +0200 you wrote:
> > 
> > New version.
> > 	Albeu
> 
> thx, mostly applied
> 
> i've fixed it for mga too, but while doing it i found a design issue
> :(((( dont worry, not a big thing.
> currently we have VOCTRL_RESIZE_DEST, with int[4] params where -1 means
> unchanged. this is bad, as -1 may be valid!
> for example when the overlay window is dragged halfway outside of the
> screen(window have negative x position, and so the overlay have too).
> The original purpose of this control was to allow caller (UI) to do
> hw-accelerated pan&scan and zoom of image. Even in that case x,y may be
> <0
Strange that none thought to it before :)

> Probably (re-)adding VOCTRL_MOVE_DEST could solve the problem, but i
> wanna know if you see other posisble problems too.
> (originanly it was there, but then i find that passing x,y to
> RESIZE_DEST makes more sence. i was wrong...)
It's ok, imho.

> if no objections or better ideas, i'll go for VOCTRL_MOVE_DEST
> (and VOCTRL_MOVE_SRC)
But for SRC i don't think we'll really need another control, as
negative x,y can be converted to w -= x, h -= y, x = 0, y = 0.
But it won't harm, to have it :)
	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.