[MPlayer-G2-dev] [PATCH] vo_tdfx_vid.c and vo_xover.c

[Alban Bedel]

Hi all,

i implemented $SUBJ. A few comments :

  tdfx_vid
I included my current tdfx_vid driver because i used some stuff wich
are not yet commited to the main cvs driver.
I tried a new "sleep" method. I discussed it a bit yesterday with Arpi
on IRC. The idea is to suppress the sleep before show_frame and give
show frame the delay needed before the frame must be displayed
(in other words the time that would have been spent sleeping).
Then in show_frame the banshee is setup to do the flip at the right
time (in fact after a given number of V-Sync). So instead of sleeping
the player can contiue.
In my test i get a good cut down on CPU by using this. A 640x272 clip
uselly need ~80% of the CPU, need only ~55% with this method.
This is according to top so it's not a so good measurment, but still.

  xover
This is not completly ready. It mostly work (with tdfx_vid) but i must say
i have been confused by VOCTRL_RESIZE_DEST. Quoting libvo2.txt :
 ---
VOCTRL_RESIZE_DEST:
    Asks the driver to redefine (move/resize) the display area.
    The parameters passed in a int[4] array: x,y,w,h. -1 means unchanged.
 ---
So i thought that this would be the position of the window/overlay on
the screen. But then in x11_helper.c i found :
 ---
    case VO_EVENT_MOVE:
        mp_msg(MSGT_CPLAYER,MSGL_V,"vo-event: moved to %d x %d\n",x,y);
// dont do that, we're moving the window, not the picture inside the window!
//        { int tmp[4];
//        tmp[2]=tmp[3]=-1; tmp[0]=x; tmp[1]=y;
//        vo->control(vo,VOCTRL_RESIZE_DEST,tmp);
//        }
 ---
So it then seemed that this control was intended for something else ?
Anyway i uncommented this and used the control for overlay resize/move.
If this control is really intended for another use, wich one should
i use ? A new one ?
	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo.g2.diff
Type: application/octet-stream
Size: 70554 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-g2-dev/attachments/20030717/f15035a1/attachment.obj>