[MPlayer-DOCS] incomprehensibility in encoding guide

Guillaume POIRIER poirierg at gmail.com
Thu Jan 4 14:08:15 CET 2007


On 1/4/07, Andrew Savchenko <Bircoph at list.ru> wrote:
> Hi,
> On 4 Январь 2007 01:04 Guillaume POIRIER wrote:
> > > > As far as I can tell from the code and a couple quick tests,
> > > > the situation with mbd and mbcmp is still the same: when all
> > > > other *cmp options are 0 (the default), making mbcmp nonzero
> > > > will have a beneficial effect on quality regardless of what
> > > > mbd is set to. When mbd is set to 1 or 2, the specific value
> > > > of mbcmp is ignored, except to check whether it is nonzero.
> > > > When mbd is 0, the specific value of mbcmp matters.
> > >
> > > So, maybe manpage should be updated to clarify this?
> >
> > Like this?
> Almost, but IMHO it would be nice to mention that "When mbd is set
> to 1 or 2, the specific value of mbcmp is ignored, except to check
> whether it is nonzero." or something similar.

Isn't that overly verbose?
We already have:

.B mbd=<0\-2>
Macroblock decision algorithm (high quality mode), encode each macro
block in all modes and choose the best.
This is slow but results in better quality and file size.
.PD 0
.IPs 0
Use comparison function given by mbcmp (default).


  .B mbcmp=<0\-2000>
Sets the comparison function for the macroblock decision, has only
an effect if mbd=0.

I'm not saying that it wouldn't help getting the point across to add
your suggested sentence somewhere in the docs. It just seems to be
redundant, and I'm not sure which spot in the doc should carry that

> And your patch seems to be slightly redundant, affecting
> non-related dvdsub_id and so on.

Yeah, that's what happens when you don't read the patches you send ;)

An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)

More information about the MPlayer-DOCS mailing list