[MPlayer-DOCS] DOCS/tech/cvs-howto.txt

[Diego Biurrun]

On Thu, Jun 22, 2006 at 04:04:37PM +0200, Ivo wrote:
> On Thursday 22 June 2006 00:32, Ivo wrote:
> > I didn't got to writing something today, but I will try to come up with a
> > short version of section III tomorrow. Something describing a typical
> > development procedure, like checkout, edit, create patch, send patch to
> > mailinglist, fix, etc, commit. We could decide later what to do with it.
> > Like replace section III, add it to section I, or just bin it ;)
> 
> See attachment.

Some more comments, orthogonal to what the Wanderer already mentioned...

> 3. Create a patch:
> 
>   Run svn diff from the source of the svn tree, like this:

Here and in other places, I'd refer with 'svn' to the commands and with
'Subversion' to the name of the revision control system.

> 4. Check the patch:
> 
>   Checkout another, clean svn source tree and verify your patch:
> 
>     patch -p1 --dry-run < my_changes.patch

It should be -p0 rather than -p1, we have to assume changing to the
directory with the new source tree...

> 5. Submit the patch:
> 
>   Send an e-mail to the mplayer-dev-eng mailinglist. Describe what your

mailing list, same below

> 7. Commit the patch:
> 
>   If your patch is accepted, commit with:
> 
>     svn commit filename(s)
> 
>   Go to step 2 ad infinitum until MPlayer is the perfect Media Player ;)

media player

Somewhere it should be mentioned that you should *always* doublecheck
changes with 'svn diff' before finally committing.  Also, the
distinction of the workflow between maintained and unmaintained code
could be a bit more explicit.

Nice work.

Diego