[MPlayer-DOCS] Re: [PATCH] x264 encoding guide

[Guillaume POIRIER]

Hi,

On 5/2/05, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, Apr 30, 2005 at 11:41:44PM +0200, Guillaume POIRIER wrote:
> > +  <listitem><para>Trading off encoding time vs. quality</para></listitem>
> 
> Somehow this sounds wrong to me, maybe some of the native speakers can
> comment.  "Trading off" feels strange, I'd say "make a tradeoff" or
> something similar, the "vs" sounds even stranger.

I don't know either. I'll change that if someone can suggest a good
replacement before I commit this (probably at noon), otherwise it'll
be fixed later.

> > +  Note that these videos can't be read by libavcodec-based decoders
> > +  older than about March 12, 2005.
> 
> Maybe add the build number?

I did not find one for this specific one. Plus I think that the commit
that allowed "pyramid B-Frames" to work isn't the one of March 12 but
of March 4:

 Revision 1.97: H.264: decode arbitrary frame orders and allow
B-frames as references.

I guess I should at least change that too.


> > +  of expensive I-frames; using weighted prediction in bframes
> 
> B-frames
> 
> I think it should always be either B-frames or <option>bframes</option>.

I think I've made all the appropriate replacements now.


> > +  I think this is almost never a good idea, and in my experience,
> > +  people who are doing this don't understand very well how
> > +  deblocking works by default.
> 
> I would say avoid the first person perspective, it's not the style of
> the MEncoder documentation.

That one slipped through.


> > +  H.264 decoding, you might keep an eye on
> > +  <ulink url="http://mplayerhq.hu/cgi-bin/cvsweb.cgi/ffmpeg/libavcodec/h264.c?cvsroot=FFMpeg">FFmpeg CVS repository's web interface</ulink>.
> 
> on the
> 
> Looks good overall.  Please replace short forms by long forms everywhere.

There is a lot more in the full XML file. I've made the appropriate
replacement, and try to made 2 clean commits with those.

Regards,
Guillaume