[MPlayer-DOCS] CVS: main/DOCS/man/en mplayer.1,1.709,1.710

[danny]

Alle 14:55, sabato 11 settembre 2004, Diego Biurrun ha scritto:
> Daniele Forghieri CVS writes:
> > Modified Files:
> > 	mplayer.1
> > Log Message:
> > Video driver null, yuv4mpeg, gif89a, pgm, png and tga documented, jpeg
> > drop from the list to document
> >
> :-)
> :
> >  .B null\ \ \
> >  Produces no video output.
> >  Useful for benchmarking.
> > +Actually there are no suboptions available.
>
> Just leave this out, it's not necessary to mention this explicitly,
> same below.
>
	I put this to clarify that is documented.

> >  The format is the same as the one employed by mjpegtools, so this is
> >  useful if you want to process the video with the mjpegtools suite.
> > +It support the YV12, RGB (24 bpp) and BGR (24 bpp) format.
>
> supports
>
	yes

> > +.PD 0
> > +.RSs
> > +.IPs interlaced
> > +Write the output as interlaced frames, top field first.
> > +.IPs interlaced_bf
> > +Write the output as interlaced frames, bottom field first.
> > +.RE
> > +.PD 1
> > +.br
> > +.I NOTE:
>
> This is broken, now NOTE: is displayed at the same indentation level
> as the option, but it should be at the indentation level of the option
> desctription.  Use .RS to fix this, look at the -fstype option as an
> example.
>
> The same applies below.
>
	ok
> > +If you don't specify any option the output is progressive (ie. no
> > interlace).
>
> i.e.\&
>
> > +You must specify only one option.
>
> Hmm, I think you can safely leave this out, the suboptions clearly do
> the opposite, they cannot both work simultaneously.
>
	Every output module does its option parsing (this MUST be fixed IMHO) and if 
you pass "interlace:interlace_bf" it will generate an error.

	In the jpeg module if you pass "progressive:noprogressive:progressive" the 
program use the last if found

> >  .B gif89a\
> > -Output each frame into a GIF file in the current directory.
> > -Each file takes the frame number padded with leading zeros as name.
> > +Output each frame into a single animated GIF file in the current
> > directory. +It support only RGB format with 24 bpp and the output is
> > converted to 256
>
> supports
	ok
>
> > +.IPs fps\ \ \
> > +Float value to specify framerate (default: 5).
> > +.IPs filename
> > +Specify the output filename (default: out.gif).
>
> I'd write ./out.gif here to clarify again that it goes into the
> current directory.
>
	ok
> How do you specify these suboptions?
>
>   -vo gif89a:25:/tmp/foo.gif
>
	this way
		
> or
>
>   -vo gif89a:fps=25:filename=/tmp/foo.gif
>
> In the former case you should write <fps> and <filename>, in the
> latter fps=<value> and filename=<value>.
>
> > @@ -2724,16 +2751,33 @@
> >  .B pgm\ \ \ \
> >  Output each frame into a PGM file in the current directory.
> >  Each file takes the frame number padded with leading zeros as name.
> > +It support only YV12 format.
>
> Only supports the YV12 format.
>
	ok
> > +The resulting image is (width) * (height * 1.5) of the original
> > +image.
> > +At coordinate 0,0 for w,h you have the Y plane, at coordinate 0,h for
>
> coordinates
>
> > +w/2,h/2 you have the U plane and at w/2,h for w/2,h/2 you have the V
> > plane.
>
> I'd write width and height explicitly instead of w and h.
>
	ok
> >  .B png\ \ \ \
> >  Output each frame into a PNG file in the current directory.
> >  Each file takes the frame number padded with leading zeros as name.
> > +It support RGB and BGR format with 24 bpp.
>
> 24bpp RGB and BGR formats are supported.
>
	I don't like start a setence with a number, in italian is a think you 
normally don't do 

> > +Actually there are no suboptions available but you can specify
> > +the compression level with the -z option, ranging from 0 (no
> > +compression) to 9 (maximum compression).
>
> Leave this out and just add (also see \-z) to the output driver name.
>
	ok
> Somebody should convert the -z option into a suboption.  Ivo, you've
> done this for -jpeg, could you repeat it for -z?
>

	I was thinking at the same while i look at the code. Shioud be very simple
> >  .TP
> >  .B tga\ \ \ \
> >  Output each frame into a Targa file in the current directory.
> >  Each file takes the frame number padded with leading zeros as name.
> > +The reason for this output video driver is to have a simple lossless
> > +image writer to use without any external library.
> > +It support BGR[A] color format, with 15, 24 and 32 bpp.
>
> supports the
	ok
>
> > +To force a particular format use the -vf format filter, e.g.\&
>
> You can force a particular format with the format video filter.
>
> > +-vf format=bgr15 to save images with 2 bytes per pixel.
>
> Please format this as a "real" example.
>
	ok
> > +Actually there are no suboptions available.
> > +
> >  .
>
> Don't add empty lines to the man page, empty lines are interpreted by
> groff.
>
	yes, I found that line when I look at the CSV log, not when i review the 
patch on my portable!

> Diego
>
> _______________________________________________
> MPlayer-DOCS mailing list
> MPlayer-DOCS at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-docs

	I start to correct the doc immeduiately and I try to take a look at some 
other video driver

	Daniele Forghieri