[MPlayer-DOCS] [PATCH] XviD documentation reaching almost completeness

Diego Biurrun diego at biurrun.de
Tue Sep 7 12:31:40 CEST 2004


Guillaume POIRIER writes:
> Le mar 07/09/2004 à 02:20, Diego Biurrun a écrit :
> > > > 
> > > > I'm not sure if we shouldn't write mpeg and h263 here since the text
> > > > refers to the parameters passed to XviD.  It's not completely clear
> > > > in which way it is meant to be understood, though.
> > > 
> > > What I'm trying to say here is that the only current parameters allowed
> > > here are: h263 or mpeg. For the rest, I guess it's just a matter of
> > > taste.
> > 
> > Yes.  And if you are talking about the quant_type parameters they
> > should be written lowercase to avoid confusion.  IOW mpeg is the
> > parameter that turns on MPEG quantization.  Does this make things more
> > clear?
> 
> So even clearer description could be:
> 
> +.B quant_type=<h263|mpeg>
> +Sets the type of quantizer to use.
> +For high bitrates, you will find that MPEG quantization preserves
> +more detail.
> +For low bitrates, the smoothing of H.263 will give you less block
> +noise.
> +When using custom matrices, MPEG quantization must be used.
> 
> Do we agree that <h263|mpeg> sums up what are the parameters available?

Yes, it sums it up.  I was under the impression that using the
parameter names directly in the description would make things
clearer.   It's minor and I may be wrong, though.

Please make the changes suggested by me and the Wanderer and commit.

> > P.S.: Guillaume, it would help the readability of your mails if you
> > could leave a blank line between a quote and your answer.  Thanks.
> 
> Ok, I'll try to do my best. 

Thanks

Diego




More information about the MPlayer-DOCS mailing list