[MPlayer-DOCS] CVS: main/help help_mp-en.h,1.111,1.112

[Dmitry Baryshkov]

Hello,
On Mon, Nov 03, 2003 at 03:40:19AM +0100, Diego Biurrun wrote:
> Diego Biurrun writes:
>  > Richard Felker CVS writes:
>  >  > -#define MSGTR_EnterTelecineMode "\ndemux_mpg: 3:2 TELECINE detected, enabling inverse telecine fx.\nFPS changed to %5.3f!\n"
>  >  > +#define MSGTR_EnterTelecineMode "\ndemux_mpg: 24fps progressive NTSC content detected, switching framerate.\n"
>  > 
>  > Shouldn't we also change
>  > 
>  > 	    mp_msg(MSGT_DECVIDEO,MSGL_INFO,MSGTR_EnterTelecineMode,sh_video->fps);
>  > 
>  > in libmpdemux/video.c to
>  > 
>  > 	    mp_msg(MSGT_DECVIDEO,MSGL_INFO,MSGTR_EnterTelecineMode);
>  > 
>  > ?
> 
> As Rich pointed out in IRC the translations still have that line.  The
> solution IMHO is to just remove the line from all translated files, it
> has to be redone anyways.
> 
> Maybe we should even make this into policy.  This way people will
> always get up to date messages and translators will not forget to
> update some messages.  Missing messages always get noticed, reworded
> messages sometimes do not.

I suppose IMHO we should make this into policy: If the message is
changed, it's name (#define'd) also _must_ be changed.

-- 
With best wishes
Dmitry Baryshkov