[MPlayer-dev-eng] [PATCH 2/6] gui: Use new lavc decode API for PNG decode.

Reimar Döffinger * at reimardoeffinger.de
Thu Dec 31 21:17:50 EET 2020

Would  you like to commit your version? While I’m still a fan of detailed discussion I end up not really having time, and it’s really all just nitpicking...

> On 21 Dec 2020, at 22:10, Ingo Brückl <ib at wupperonline.de> wrote:
> Reimar Döffinger wrote on Mon, 21 Dec 2020 21:21:59 +0100:
>> The main difference is that I changed decode_ok to preserve the exact
>> error return value, mostly because I thought it might be useful for
>> debug.
> There is no need to do so.

It probably looks better without I admit, I just implemented it with the expectation that it wouldn’t work on first try, thus why it ended up like that.

>> I thought that there was not much sense in checking the send_packet
>> result though.
> I don't know ffmpeg internals, but just went by the documentation which
> says it returns 0 on success.

My thinking was that we don’t care if send_packet succeeds or not (e.g. could it maybe fail if there is some extra garbage data at the end?), we only care if we get a decoded image out.

More information about the MPlayer-dev-eng mailing list