[MPlayer-dev-eng] [PATCH] Read scratched DVDs, warn for corrupt titles and report number of cells in title

[Erik Auerswald]

Hi Micah,

On Sat, May 05, 2018 at 01:23:37AM +0200, Erik Auerswald wrote:
> On Sat, Jan 27, 2018 at 06:10:14PM -0800, Micah Richert wrote:
> > This patch does 3 things:
> > Continues to next cell when DVD sector read fails instead of the
> > current behavior of failing/signaling EOF.  This is useful for
> > playing scratched DVDs.

As a first test of your patch I tried to play a scratched DVD. Without
your patch, the DVD plays until the damaged part is reached, then
MPlayer will exit after unsuccessfully trying to read the disk.

With your patch, the movie does not even start. MPlayer prints the
following befor exiting:

--------8<--------
Packs out of order! Current pack: 0x2B4F9C next pack: 0x0. Likely corrupt title.
Selected DVD audio channel: 128 language: en
Cache fill:  0.05% (2048 bytes)   



Exiting... (End of file)
--------8<--------

(The damage to the DVD is light enough that carefully cleaning before
playback often suffices to allow watching the complete movie.)

I'd say there are problems with your patch. :-(

Thanks,
Erik
-- 
[A]pplied cryptography mostly sucks.
                        -- Green's law of applied cryptography