[MPlayer-dev-eng] [PATCH] Add support for default of multiple video tracks
ib at wupperonline.de
Thu Jan 30 02:05:13 CET 2014
Reimar Döffinger wrote on Wed, 29 Jan 2014 21:36:30 +0100:
> On 29.01.2014, at 19:59, Ingo Brückl <ib at wupperonline.de> wrote:
>> Reimar Döffinger wrote on Wed, 29 Jan 2014 19:09:47 +0100:
>>> On Wed, Jan 29, 2014 at 06:20:42PM +0100, Ingo Brückl wrote:
>>>> Reimar Döffinger wrote on Tue, 28 Jan 2014 19:12:14 +0100:
>>>>> My suggestions would be [...]
>>>> Implemented in this revision of the patch.
>>>> I'm still testing but I don't expect it to break anything.
>>> While I think some of that logic is still fishy, I'd say go ahead.
>>> Though I'd appreciate if you just add the same lines to mencoder.c
>>> around line 716 (I guess you maybe just forgot?).
>> I totally forgot about mencoder, please see the attached patch for the v3
>> 1. I didn't change the line the switching statement was/is in, or should I?
> You put it in the code handling program switching.
Although I don't fully understand this part of mencoder, I see now.
> I meant putting it right above the select_audio just like in mplayer.
> Though double-checking the interaction with this program handling might
> be necessary.
I am just asking myself whether the demuxer_switch_video() call would be
redundant now and can be removed.
If prog.vid can be -1 and if demuxer_switch_video(..., -1) actually performs
something, the call must remain. Else it will be superfluous, because the new
select_video() will do the job now.
I was trying to understand DEMUXER_CTRL_IDENTIFY_PROGRAM and
demuxer_switch_video(), but failed.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 638 bytes
Desc: not available
More information about the MPlayer-dev-eng