[MPlayer-dev-eng] [PATCH] Add support for default of multiple video tracks
Reimar.Doeffinger at gmx.de
Wed Jan 29 21:36:30 CET 2014
On 29.01.2014, at 19:59, Ingo Brückl <ib at wupperonline.de> wrote:
> Reimar Döffinger wrote on Wed, 29 Jan 2014 19:09:47 +0100:
>> On Wed, Jan 29, 2014 at 06:20:42PM +0100, Ingo Brückl wrote:
>>> Reimar Döffinger wrote on Tue, 28 Jan 2014 19:12:14 +0100:
>>>> My suggestions would be [...]
>>> Implemented in this revision of the patch.
>>> I'm still testing but I don't expect it to break anything.
>> While I think some of that logic is still fishy, I'd say go ahead.
>> Though I'd appreciate if you just add the same lines to mencoder.c
>> around line 716 (I guess you maybe just forgot?).
> I totally forgot about mencoder, please see the attached patch for the v3
> 1. I didn't change the line the switching statement was/is in, or should I?
You put it in the code handling program switching.
I meant putting it right above the select_audio just like in mplayer.
Though double-checking the interaction with this program handling might be necessary.
> 2. Do we need a handling for video_id == -2? (It is missing in the v3 patch;
> please see the change to mpcommon.c.)
I don't think so, it's not there for audio.
I'd rather have consistent code, the complexity just gets unmanageable otherwise.
More information about the MPlayer-dev-eng