[MPlayer-dev-eng] [patch] fix playback of 8-bit audio when sndio ao is used

[Brad Smith]

On 26/02/14 2:56 PM, Reimar Döffinger wrote:
> On Tue, Feb 25, 2014 at 03:18:20AM -0500, Brad Smith wrote:
>> On 17/02/14 1:18 PM, Alexandre Ratchov wrote:
>>> Hi,
>>>
>>> This diff unbreaks playback of u8 audio. AFAIU, the endianness bit
>>> must be set to AF_FORMAT_NE for 8-bit formats.
>>
>> Any comment regarding this diff?
>
> I tried with hacking other aos to advertise the "wrong" endianness
> for 8-bit formats and I didn't see any major issues, so I don't know what
> the problem is it fixes?

The issue is we were provided a u8 sample clip where playing the clip
resulted in no audio output at all. With the diff applied the audio
played as expected.

$ mplayer bitchsong.mov
MPlayer SVN-r36572 (C) 2000-2014 MPlayer Team

Playing bitchsong.mov.
libavformat version 54.63.104 (external)
libavformat file format detected.
[lavf] stream 0: video (cinepak), -vid 0
[lavf] stream 1: audio (pcm_u8), -aid 0, -alang eng
VIDEO:  [cvid]  160x120  24bpp  30.000 fps  521.0 kbps (63.6 kbyte/s)
Clip info:
  creation_time: 1998-01-14 14:56:03
  premiere_version: Created with Adobe Premiere\xaa 4.2
  quicktime_version: Created with QuickTime 2.0 or later
Load subtitles in ./
==========================================================================
Opening video decoder: [ffmpeg] FFmpeg's libavcodec codec family
libavcodec version 54.92.100 (external)
Selected video codec: [ffcvid] vfm: ffmpeg (FFmpeg Cinepak Video)
==========================================================================
==========================================================================
Opening audio decoder: [pcm] Uncompressed PCM audio decoder
AUDIO: 11127 Hz, 1 ch, u8, 89.0 kbit/100.00% (ratio: 11127->11127)
Selected audio codec: [pcm] afm: pcm (Uncompressed PCM)
==========================================================================
AO: [sndio] 11127Hz 1ch ?? (1 bytes per sample)
Starting playback...
Could not find matching colorspace - retrying with -vf scale...
Opening video filter: [scale]
Movie-Aspect is undefined - no prescaling applied.
[swscaler @ 0x4c15931d120]BICUBIC scaler, from rgb24 to yuv420p using MMXEXT
VO: [xv] 160x120 => 160x120 Planar YV12

> There was a small issue in the printout and it would cause a point
> "endianness conversion" to be inserted.
> I just made the audio_out.c code normalize the 8 bit formats.
> So now it definitely shouldn't be causing any issues anymore.

I'll try the latest code and see what happens.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.