[MPlayer-dev-eng] gui: subtitle menu is not populated when playing from mpg file

[Reimar Döffinger]

On Tue, Aug 12, 2014 at 04:03:58PM +0200, Ingo Brückl wrote:
> Lode Leroy wrote on Fri, 1 Aug 2014 16:30:25 +0200:
> 
> > please consider the following fix for mplayer -gui...
> 
> > mpctx_get_global_sub_size(guiInfo.mpcontext);
> > is not returning the number of subtitles, because
> > void update_global_sub_size(MPContext *mpctx)
> > was not called to update it.
> 
> Well, this is because of the mpg demuxer (lavf works fine by the way).
> 
> Apparently the mpg demuxer can detect subtitles only while playing, but
> MPlayer has already finished updating subtitle information then.
> 
> In order to really fix the cause, update_global_sub_size() should be called
> prior to returning MPContext global_sub_size information. Unfortunately,
> update_global_sub_size() cannot be static any longer then.
> 
> I consider this a better solution that adding some update_global_sub_size()
> code to the GUI.
> 
> Opinions?

I would think that the global sub size variable ideally should be kept
up-to-date automatically. I guess that is one way to make that happen,
I was just more wondering why it doesn't happen automatically once we
got a new subtitle stream, instead of on every read of that variable.