[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

[Ingo Brückl]

I wrote on Fri, 11 Apr 2014 11:08:36 +0200:

> Hans-Dieter Kosch wrote on Fri, 11 Apr 2014 02:40:58 +0200:

>> Ingo Brückl wrote:

>> If you agree, I'd work out the patch for this feature change, taking you
>> off the work.

> Thank you very much for your kind offer, but I have to confess that I've
> already prepared the changes last night. I thought that it would be a good
> idea to already test them along with the rpotmeter patch so that I can
> commit both on the weekend to have all off the table. (And hopefully there
> will be no new bugs then.)

Well, and as soon as you try to change a simple feature you're meeting a peck
of troubles...

When you click on a potmeter button to grab it, it would already move due to
its new value now. :-(

So it would be necessary to check whether the mouse pointer is inside the
button which isn't easily possible at the moment. The best way to realize
this would be to store the button's position in render.c to additional
members of guiItem in order to be able to access this information in
main.c/playbar.c - which, frankly, doesn't seem worth the effort to me,
because we'll be running into the next problem for clicks inside the button
then, because these kinds of small changes won't be able any longer without
having wsRLMouseButton code anyway.

Nah! But if you insist, file a trac feature request, but don't expect
acceptance of an implementation that will increase code complexity for
almost no benefit.

Ingo