[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

Ingo Brückl ib at wupperonline.de
Fri Apr 11 11:08:36 CEST 2014


Hans-Dieter Kosch wrote on Fri, 11 Apr 2014 02:40:58 +0200:

> Ingo Brückl wrote:

>> For a simple click, we don't need wsRLMouseButton, and for dragging the
>> value should already have been set by wsMoveMouse.

> Exactly, that's also my conclusion.

>> I'll approach it immediately after committing the rpotmeter patch (and it
>> will be the last feature change for a while, because I desperately need a
>> break.)

> Well, it was an exhaustive but successful discussion so far and you
> committed myriads of reworks meanwhile moreover.

Yeah, something over 200 since you've proposed "item->pressed = btnReleased"
to activate potmeter two month ago (not necessarily all 200 directly related
though).

> If you agree, I'd work out the patch for this feature change, taking you
> off the work.

Thank you very much for your kind offer, but I have to confess that I've
already prepared the changes last night. I thought that it would be a good
idea to already test them along with the rpotmeter patch so that I can commit
both on the weekend to have all off the table. (And hopefully there will be
no new bugs then.)

Ingo


More information about the MPlayer-dev-eng mailing list