[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

Hans-Dieter Kosch hdkosch at kabelbw.de
Thu Apr 10 03:35:39 CEST 2014


Ingo Brückl wrote:

> Hans-Dieter Kosch wrote on Tue, 08 Apr 2014 01:08:47 +0200:
> 
>> It works :-)
> 
> I hope this here works even better.

> Although I'm going to review the patch by myself taking my time when being
> well rested, I'd appreciate reviews, tests and reports if there are issues.

Seems all fine, no issues detected.

One feature request: You made the rpotmeter reacting immediately to the pressing 
of the mouse button by

   uiEvent( item->message,100.0 * prev_point / item->arclength );

It would then be nice and consistent to have this feature for the other 
potmeters, too. It gives in fact more intuitive behaviour on clicking and dragging!

Hans-Dieter


More information about the MPlayer-dev-eng mailing list