[MPlayer-dev-eng] [PATCH] GUI: Implement a true rotary potmeter

[Hans-Dieter Kosch]

Ingo Brückl wrote:

> Hans-Dieter Kosch wrote on Thu, 10 Apr 2014 04:11:19 +0200:
> 
>> Ingo Brückl wrote:
> 
>>>> 1. What delimiter / method should be used for the extra x0, y0, x1, y1?
>>> Of all reasonable characters available for the current method (adding to
>>> default value), maybe the slash is the better choice?
>>>
>>>   rpotmeter = NULL, 0, 0, volume, 51, 0/49/52/60/26, 189, 126, 61, 57, evSetVolume
> 
>> That looks not bad. But why bind them to the default value and not really
>> separate them by comma, they have logically nothing to do with the default.
> 
> I've come to the same conclusion meanwhile after a snatch of sleep and have
> already changed it to:
> 
>   rpotmeter = button, bwidth, bheight, phases, numphases, x0, y0, x1, y1, default, X, Y, width, height, message

That looks really good!

> Thanks for persisting anyway. This kind of debate helps finding better
> solutions.

Don't mind, I'm glad that you appreciate :-) MPlayer is my favourite player and 
open source gives me so much, so I feel for giving back something to the community.

Hans-Dieter