[MPlayer-dev-eng] [PATCH] GUI: Potmeter button corrections

[Ingo Brückl]

Hans-Dieter Kosch wrote on Tue, 01 Apr 2014 04:04:04 +0200:

> Ingo Brückl wrote:

>> A correct fix would be to make the middle of the button the representative
>> for the item's value, but that would result in a button that would stick
>> out at the edges half a button size.

> Middle of the button, right, that's what my patch does in mouse capturing;
> the rendering is already correct. And this way, the button will never
> exceed the edges.

Yes, but your patch shortens by a button size the part of the potmeter slide
area that returns different values, or - to put it another way - the areas
half a button size at the edges return the same values, i.e. 0% is everywhere
between the left edge and half a button size at the right. Compared with the
current behaviour, *that* would be confusing. Where would I have to click for
a little bit over 0%? Certainly not a few pixels right to the left edge. This
is still 0%.

> I understand your aim for abstraction, but both capturing and rendering are
> bound to the same screen positions, and the related calculations must
> match; I see no way around.

Maybe I'm getting your point when I'm looking over the rpotmeter patch, but
for the current potmeters I really don't (and never did) see a problem
(which, of course, could be because I'm used to their behaviour).

>> While this is exactly what a real poti does, this unfortunately never
>> seemed to be the design plan for the GUI and thus no skin is prepared to
>> handle it.

> What do you mean by design plan?

I meant that the people that had set up the rules for skins didn't plan to
have potmeter buttons that stick out at the edges, hence all skin designs
rely on it and a button sticking out may overlap or come too close to an
other skin item then.

Ingo