[MPlayer-dev-eng] [PATCH] GUI: Potmeter button corrections

Hans-Dieter Kosch hdkosch at kabelbw.de
Tue Apr 1 04:04:04 CEST 2014


Ingo Brückl wrote:

> A correct fix would be to make the middle of the button the representative
> for the item's value, but that would result in a button that would stick out
> at the edges half a button size.

Middle of the button, right, that's what my patch does in mouse capturing; the 
rendering is already correct. And this way, the button will never exceed the edges.

I understand your aim for abstraction, but both capturing and rendering are 
bound to the same screen positions, and the related calculations must match; I 
see no way around.

> While this is exactly what a real poti does,
> this unfortunately never seemed to be the design plan for the GUI and thus no
> skin is prepared to handle it.

What do you mean by design plan? A skin definition gives the layout, but placing 
  variable elements inside the skin like a potmeter button is finally handled by 
the code, of course regarding the constraints given by the skin definition.

Hans-Dieter


More information about the MPlayer-dev-eng mailing list