[MPlayer-dev-eng] [PATCH] ao_jack: add "connect" suboption

[Markus Appel]

On 05/04/2013 11:57 PM, Reimar Döffinger wrote:
> On Sat, May 04, 2013 at 11:06:28PM +0200, Markus Appel wrote:
>> If you want to get all available audio channels, you can now use
>> "-ao jack:noconnect" and manually create whatever connections you
>> desire.
>
> Hm, it seems reasonable to me to at least connect the outputs
> that exist.
> Could you try updating and see if the behaviour if you only comment
> out this line:
>
>> -  if (channels > i) channels = i;
>
> Seems good to you?

In my opinion, there should be two possibilities of using jack output:

  - "simple" behavior, if you have e.g. a 6-channel soundcard, ask 
mplayer for "-channels 6 -ao jack" and get 1-to-1 connections without 
worrying about it

- "flexible" behavior, in case you have e.g. multiple stereo soundcards 
(like me) or a 6-channel soundcard with non-standard channel sequence, 
then you ask for "-channels 6 -ao jack:noconnect" and configure e.g. 
qjackctl's patchbay to reroute the channels to wherever you want. 
Connecting to the existing outputs in the latter case does not really 
help, you will likely not get usable audio by just doing that (missing 
dialogues from a not connected center channel for example), and it might 
get in the way of your custom connection template.

I hope I could convince you ;) I attached a diff to r36233.

Anyway, thanks for the revision so far.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer36233_jack_connect.patch
Type: text/x-patch
Size: 3763 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20130505/bb6b4b44/attachment.bin>