[MPlayer-dev-eng] [PATCH] Support newer GIFLIB versions

Alexander Strasser eclipse7 at gmx.net
Mon Jul 22 19:19:41 CEST 2013


Hi Andïï,

On 2013-07-22 13:37 +0100, Andïï wrote:
> On 21 July 2013 23:20, Alexander Strasser <eclipse7 at gmx.net> wrote:
> > Work with GIFLIB version >= 4.2
> >
> 
> Looking at the patch, the main changes seem to be for 5 and I already
> posted a patch for this some time ago:
> 
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2013-May/071631.html

  I am sorry I somehow missed it. I noticed something today that
you have addressed in your patch. My version builds with version
5 and higher but it misses changes regarding EGifPutFirst/Leader
and friends for vo gif89a. So I still need to adress those.

> Apologies for not yet following up on the changes.  Given the response
> to this patch, do we still want to break compatibility with giflib <
> 5, as suggested in the previous thread?

  As I mentioned in reply to Carl Eugen I was in favour of keeping
support for older versions. But I am fine with dropping too; I do not
know any use case (except comparison and development) where GIFLIB
support is essential. Also if someone has use cases please speak up.

  *But* I differ in one point with what Reimar said in earlier discussion
with you, I do think we should *strongly* decide for dropping support of
earlier versions or *not* drop at all. Re-adding later is from the experience
I have with working on this until now, not something I would like to do.

  Thank you for pointing me to your patches and their discussion.

  Alexander


More information about the MPlayer-dev-eng mailing list