[MPlayer-dev-eng] [PATCH] change aspect ratio in gtk gui

[Ingo Brückl]

Reimar Döffinger wrote on Sat, 13 Jul 2013 01:28:11 +0200:

> On 12.07.2013, at 02:32, Ingo Brückl <ib at wupperonline.de> wrote:
>>
>> Part 1: Add missing XFree() - necessary for glXChooseVisual() as well.

> Hm, I have never seen this in valgrind, which makes this a bit suspicious
> to me.
> Could reproduce a leak?

I was just relying on the documentation (e.g.
http://www.talisman.org/opengl-1.1/Reference/glXChooseVisual.html) and since
I needed it for the getWindowVisualInfo()...

>> Part 2: Add if/else for WinID.

> Especially for the stereo case I think it's unlikely to work well that
> way.
> A more extreme case if it's a visual that is not OpenGL compatible...

I can't say much about that, but shouldn't the owner of WinID be responsible
for that?

Maybe vo_find_depth_from_visuals() should be improved to find a suitable
visual in case of gl and the GUI, which calls it anyway, should take this
very visual instead of calling XMatchVisualInfo() afterwards for its visual
(which seems to be senseless even now).

> Lastly, I would expect this issue exists also for egl/GLES so I think
> it's only a partial solution

No such support here, so I can't say anything on that topic.

Ingo