[MPlayer-dev-eng] Should there be movie_aspect and stricter prescaling checks?

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Aug 7 22:11:28 CEST 2013

On 07.08.2013, at 17:26, Ingo Brückl <ib at wupperonline.de> wrote:

> Reimar Döffinger wrote on Wed, 07 Aug 2013 08:59:47 +0200:
>> "Ingo Brückl" <ib at wupperonline.de> wrote:
>>> Option "aspect" (variable movie_aspect) is restricted to range 0.1..10.0
>>> in cfg-common.h.
>>> Command switch_ratio allows any value for movie_aspect in command.c and
>>> there is already prescaling for sh->aspect > 0.01 in vd.c.
>>> Should there be checks for the above range and prescaling only start if
>>> greater or equal 0.1, or is it ok for the switch_ratio command to leave
>>> the range of the aspect option? Should the range start with 0.01?
>> I think it is reasonable for the command line to be more restricted.
> I agree. My point was that all this should be consistent. It's kinda hard to
> understand why option aspect starts from 0.1 and prescaling starts if > 0.01

Well, as I tried to explain, command-line is more likely due to typo or so, UIs using the slave mode interface hardly make typos.
I don't mind if you prefer to change it though.

> while it is allowed to set sh->aspect to a negative value > -1.0 and < 0
> (which doesn't affect scaling, but gives wrong aspect information in sh).

Shouldn't cause an error when it rejects the value?

More information about the MPlayer-dev-eng mailing list