[MPlayer-dev-eng] [PATCH] corevideo:shared_buffer broken

[Reimar Döffinger]

Xidorn Quan <quanxunzhen at gmail.com> wrote:

>On Tue, Oct 9, 2012 at 7:58 AM, Zongyao Qu <Zongyao.qu at gmail.com>
>wrote:
>
>> Xidorn Quan <quanxunzhen <at> gmail.com> writes:
>>
>> > I don't think it is where the problem is since nil can accept any
>> > message and simply ignore them without complaining.
>>
>> nil is able to be passed any message
>> only means that app will not crash.
>>
>> Since the function returns vo_true, which it actually didn't do the
>right
>> thing,
>> The return value would confuse the caller.
>> you could find some relative code in video_out.c
>>
>
>I see. A quick patch here.

Should be ok as a quick fix, but I suspect it might cause some strange effects if -fs is used with shared buffer.
I think a better solution would be to set vo_screenwidth/height to some fallback value if they are 0.