[MPlayer-dev-eng] [PATCH] corevideo:shared_buffer broken

[Xidorn Quan]

On Tue, Oct 9, 2012 at 7:58 AM, Zongyao Qu <Zongyao.qu at gmail.com> wrote:

> Xidorn Quan <quanxunzhen <at> gmail.com> writes:
>
> > I don't think it is where the problem is since nil can accept any
> > message and simply ignore them without complaining.
>
> nil is able to be passed any message
> only means that app will not crash.
>
> Since the function returns vo_true, which it actually didn't do the right
> thing,
> The return value would confuse the caller.
> you could find some relative code in video_out.c
>

I see. A quick patch here.

Index: libvo/vo_corevideo.m
===================================================================
--- libvo/vo_corevideo.m    (revision 35235)
+++ libvo/vo_corevideo.m    (working copy)
@@ -390,7 +390,9 @@
         case VOCTRL_FULLSCREEN: vo_fs = !vo_fs; if(!shared_buffer){
[mpGLView fullscreen: NO]; } else { [mplayerosxProto toggleFullscreen]; }
return VO_TRUE;
         case VOCTRL_GET_PANSCAN: return VO_TRUE;
         case VOCTRL_SET_PANSCAN: panscan_calc(); return VO_TRUE;
-        case VOCTRL_UPDATE_SCREENINFO: [mpGLView update_screen_info];
return VO_TRUE;
+        case VOCTRL_UPDATE_SCREENINFO:
+            [mpGLView update_screen_info];
+            return shared_buffer ? VO_FALSE : VO_TRUE;
     }
     return VO_NOTIMPL;
 }