[MPlayer-dev-eng] [patch] fix compilation error in gui/win32/interface.c

Alexander Strasser eclipse7 at gmx.net
Fri Nov 23 22:57:05 CET 2012


Reimar Döffinger wrote:
> On Fri, Nov 23, 2012 at 12:06:59PM -0800, Stephen Sheldon wrote:
> > On 11/23/2012 11:52 AM, Reimar Döffinger wrote:
> > >Maybe I am missing something, but it seems to me that
> > >add_to_gui_playlist should rather be removed from gui/interface.h
> > >and made static in gui/interface.c instead...
> > 
> > add_to_gui_playlist is called from several files in the gtk gui.
> 
> Yes, I missed the two from gui/gtk.
> I'd guess removing the "static" is probably the best solution then.

  Thank you for the patch, Stephen! Committed.

  I came to the same conclusions and committed the patch to un-break
the windows GUI build.

  Ingo, I hope you don't mind. If you want to fix this in a different
way, feel free to do so.

  Alexander

P.S.
The submitted patch seemed to have a additional column of spaces
because of which it failed to apply for me. I am kind of puzzled
about this.


More information about the MPlayer-dev-eng mailing list